[#GLIFFY-839] Javascript onclose check should not be applied after clicking return to confluence button

Gliffy

Javascript onclose check should not be applied after clicking return to confluence button

Created: 24/Aug/08 12:40 AM Updated: 26/Jun/09 11:48 AM

Component/s:

Confluence Plugin Integration

Affects Version/s:

Gliffy Plugin for Confluence - 1.4.1

Fix Version/s:

Gliffy Plugin for Confluence - 1.5.0

Security Level:

Anyone may view

Environment:

Gliffy 1.4.1, Confluence 2.9

Description

« Hide

The javascript check for unsaved changes on closing the gliffy window should not be applied after clicking the retuen to confluence button, the user is already presented with a save dialog in this case. (If the click cancel in the javascript box they also just get sent back to a blank diagram)

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Chris Kohlhardt added a comment - 04/Dec/08 07:45 PM

Hi Shannon,

I'm not sure I understand what the issue is here. Can you please go into more detail?

thanks!

-chris

[ Permlink | « Hide ]

Shannon Krebs added a comment - 08/Dec/08 01:59 PM

Add or edit a diagram.
Click on the return to confluence button.
You will get prompted to save the diagram by the gliffy editor
Click ok to save the diagram.
You then get prompted by a javascript warning that you are leaving the page without saving.

[ Permlink | « Hide ]

Chris Kohlhardt added a comment - 08/Dec/08 03:45 PM

I'm not seeing this behavior Shannon.

Which web browser/version/platform are you using?

-chris

[ Permlink | « Hide ]

Chris Kohlhardt added a comment - 08/Dec/08 03:47 PM

Never mind... I just reproduced this on Firefox.

[ Permlink | « Hide ]

Chris Kohlhardt added a comment - 08/Dec/08 06:32 PM

There is something wrong with the Flash to Browser communication.

[ Permlink | « Hide ]

Chris Kohlhardt added a comment - 10/Dec/08 05:57 PM

There seems to be some strange timing effect going on where by variables in gliffy.js aren't being set immediately. Thus, what happens is the save warning isn't turned off in time. Simply making sure that the save warning is set to the new value as the first statement, AND adding a LzTimer delegate to the 'last page' loading seems to have given the javascript enough time to set the variables properly. Weird.