Gliffy

Javascript onclose check should not be applied after clicking return to confluence button

Details

  • Description:
    Hide

    The javascript check for unsaved changes on closing the gliffy window should not be applied after clicking the retuen to confluence button, the user is already presented with a save dialog in this case. (If the click cancel in the javascript box they also just get sent back to a blank diagram)

    Show
    The javascript check for unsaved changes on closing the gliffy window should not be applied after clicking the retuen to confluence button, the user is already presented with a save dialog in this case. (If the click cancel in the javascript box they also just get sent back to a blank diagram)
  • Environment:
    Gliffy 1.4.1, Confluence 2.9

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Kohlhardt added a comment - 04/Dec/08 7:45 PM

Hi Shannon,

I'm not sure I understand what the issue is here. Can you please go into more detail?

thanks!

-chris

Show
Chris Kohlhardt added a comment - 04/Dec/08 7:45 PM Hi Shannon, I'm not sure I understand what the issue is here. Can you please go into more detail? thanks! -chris
Hide
Permalink
Shannon Krebs added a comment - 08/Dec/08 1:59 PM

Add or edit a diagram.
Click on the return to confluence button.
You will get prompted to save the diagram by the gliffy editor
Click ok to save the diagram.
You then get prompted by a javascript warning that you are leaving the page without saving.

Show
Shannon Krebs added a comment - 08/Dec/08 1:59 PM Add or edit a diagram. Click on the return to confluence button. You will get prompted to save the diagram by the gliffy editor Click ok to save the diagram. You then get prompted by a javascript warning that you are leaving the page without saving.
Hide
Permalink
Chris Kohlhardt added a comment - 08/Dec/08 3:45 PM

I'm not seeing this behavior Shannon.

Which web browser/version/platform are you using?

-chris

Show
Chris Kohlhardt added a comment - 08/Dec/08 3:45 PM I'm not seeing this behavior Shannon. Which web browser/version/platform are you using? -chris
Hide
Permalink
Chris Kohlhardt added a comment - 08/Dec/08 3:47 PM

Never mind... I just reproduced this on Firefox.

Show
Chris Kohlhardt added a comment - 08/Dec/08 3:47 PM Never mind... I just reproduced this on Firefox.
Hide
Permalink
Chris Kohlhardt added a comment - 08/Dec/08 6:32 PM

There is something wrong with the Flash to Browser communication.

Show
Chris Kohlhardt added a comment - 08/Dec/08 6:32 PM There is something wrong with the Flash to Browser communication.
Hide
Permalink
Chris Kohlhardt added a comment - 10/Dec/08 5:57 PM

There seems to be some strange timing effect going on where by variables in gliffy.js aren't being set immediately. Thus, what happens is the save warning isn't turned off in time. Simply making sure that the save warning is set to the new value as the first statement, AND adding a LzTimer delegate to the 'last page' loading seems to have given the javascript enough time to set the variables properly. Weird.

Show
Chris Kohlhardt added a comment - 10/Dec/08 5:57 PM There seems to be some strange timing effect going on where by variables in gliffy.js aren't being set immediately. Thus, what happens is the save warning isn't turned off in time. Simply making sure that the save warning is set to the new value as the first statement, AND adding a LzTimer delegate to the 'last page' loading seems to have given the javascript enough time to set the variables properly. Weird.

People

Dates

  • Created:
    24/Aug/08 12:40 AM
    Updated:
    26/Jun/09 11:48 AM
    Resolved:
    10/Dec/08 5:57 PM
Bug tracking and project tracking for software development powered by Atlassian JIRA (v4.1.2#531) | Report a problem | Request a feature | Contact administrators