[#GLIFFY-709] Remove link should be shown when user has permission to edit page - Gliffy

Details

Type: Bug
Status: Tested
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: Gliffy Plugin for Confluence - 1.4.1
Component/s: None
Security Level: Anyone may view

Description:

Hide

I think the logic for the remove link should be something like this:

if( diagram is attached to current page ) {
    if( user has page edit permissions OR ( user has page edit permissions AND attachment remove permissions ) ) {
         show remove diagram link
    } else {
         don't show remove diagram link
    }
} else {  //diagram is attached to a page different than the current page being viewed
   if( user has page edit permissions on the current page ) {
        show remove diagram link
   } else {
        don't show remove diagram link
   }
}

Show

I think the logic for the remove link should be something like this:

if( diagram is attached to current page ) {
    if( user has page edit permissions OR ( user has page edit permissions AND attachment remove permissions ) ) {
         show remove diagram link
    } else {
         don't show remove diagram link
    }
} else {  //diagram is attached to a page different than the current page being viewed
   if( user has page edit permissions on the current page ) {
        show remove diagram link
   } else {
        don't show remove diagram link
   }
}

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Shannon Krebs added a comment - 04/Jul/08 8:25 AM

There is no real difference between the two scenarios you list above, if the user has edit permission on the page they will get the remove link. The remove action will decide if they get to remove the attachment as well.

Show

Shannon Krebs added a comment - 04/Jul/08 8:25 AM There is no real difference between the two scenarios you list above, if the user has edit permission on the page they will get the remove link. The remove action will decide if they get to remove the attachment as well.

People

Assignee:

Shannon Krebs

Reporter:

Chris Kohlhardt
Votes:

0

Watchers:

0

Dates

Created:

24/Jun/08 1:00 PM

Updated:

26/Jun/09 11:54 AM

Resolved:

04/Jul/08 8:34 AM