Gliffy

Add Diagram links don't show up for the non default themes with for Gliffy 1.4, Confluence 2.8

Details

  • Description:
    Hide

    In the 1.4 release of gliffy we added a new web item to put the add diagram link in the correct place in the new menu in the default theme. Unfortunately it appears as though some of the other themes that are bundled with confluence have not been updated to know about these new theme locations yet.

    This is causing a problem for users of these themes because we specifically disabled the old web item link in confluence 2.8+ builds because it would cause two Add Digram links to show up in the default themes menu.

    If Atlassian are not going to provide fixes for the other themes supplied with confluence (in the near future) we may need to roll back this change so the Add Digram link uses the old theme location for all Confluence builds.

    Related Forum Posts:
    http://forums.atlassian.com/thread.jspa?threadID=26522&tstart=0
    http://www.gliffy.com/forums/showthread.php?t=1238

    Show
    In the 1.4 release of gliffy we added a new web item to put the add diagram link in the correct place in the new menu in the default theme. Unfortunately it appears as though some of the other themes that are bundled with confluence have not been updated to know about these new theme locations yet. This is causing a problem for users of these themes because we specifically disabled the old web item link in confluence 2.8+ builds because it would cause two Add Digram links to show up in the default themes menu. If Atlassian are not going to provide fixes for the other themes supplied with confluence (in the near future) we may need to roll back this change so the Add Digram link uses the old theme location for all Confluence builds. Related Forum Posts: http://forums.atlassian.com/thread.jspa?threadID=26522&tstart=0 http://www.gliffy.com/forums/showthread.php?t=1238

Issue Links

Related
 

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Shannon Krebs added a comment - 24/Jun/08 6:34 AM

I created a confluence issue here: http://jira.atlassian.com/browse/CONF-12235

Show
Shannon Krebs added a comment - 24/Jun/08 6:34 AM I created a confluence issue here: http://jira.atlassian.com/browse/CONF-12235
Hide
Permalink
Chris Kohlhardt added a comment - 24/Jun/08 12:09 PM

Thanks for documenting this Shannon.

If I read this correctly, the true problem is that some themes have not been updated to work correctly with Confluence 2.8. Is that correct?

If that's the case, would it make sense to address the problem in the broken themes?

Show
Chris Kohlhardt added a comment - 24/Jun/08 12:09 PM Thanks for documenting this Shannon. If I read this correctly, the true problem is that some themes have not been updated to work correctly with Confluence 2.8. Is that correct? If that's the case, would it make sense to address the problem in the broken themes?
Hide
Permalink
Shannon Krebs added a comment - 25/Jun/08 3:44 AM

There are two ways for atlassian to fix the problem, either add support for the new web item location keys to all themes, or remove the old location from the default theme so the add diagram link doesn't show up twice in the menu.

If Atlassian aren't going to fix the problem we can just revert to using the old web item location to be compatible with all themes, the main drawback of this the add diagram link won't appear in the correct spot in the 2.8 menu.

Show
Shannon Krebs added a comment - 25/Jun/08 3:44 AM There are two ways for atlassian to fix the problem, either add support for the new web item location keys to all themes, or remove the old location from the default theme so the add diagram link doesn't show up twice in the menu. If Atlassian aren't going to fix the problem we can just revert to using the old web item location to be compatible with all themes, the main drawback of this the add diagram link won't appear in the correct spot in the 2.8 menu.
Hide
Permalink
Debi Kohlhardt added a comment - 25/Jun/08 9:08 AM

Report from Customer 6/25:
I changed our test environment to the default theme, and the diagram link is now working. It had been set to the classic theme, which I'm sure came from our restoring a backup of production to test.

Show
Debi Kohlhardt added a comment - 25/Jun/08 9:08 AM Report from Customer 6/25: I changed our test environment to the default theme, and the diagram link is now working. It had been set to the classic theme, which I'm sure came from our restoring a backup of production to test.
Hide
Permalink
Chris Kohlhardt added a comment - 30/Jun/08 12:25 PM

OK, if I understand the problem correctly, it sounds like there are several themes being used by customers that don't fully support Confluence 2.8. The best solution would be that these customers stick with themes that are designed to work with Confluence 2.8.

I don't think it's a good idea for us to switch back to using the old theme system in our plugin... we want to support the newest features as a general rule.

I propose we add a new web item plugin that works with older themes. We would ship this plugin disabled by default. The name of this web item plugin might be: Web Item to show Add Diagram link (2.8+, legacy theme support)

If a customer wants to use themes that haven't been designed to work with Confluence 2.8, they can disable the 2.8+ web item, and enable the 2.8+, legacy theme support plugin.

How does that sound?

Show
Chris Kohlhardt added a comment - 30/Jun/08 12:25 PM OK, if I understand the problem correctly, it sounds like there are several themes being used by customers that don't fully support Confluence 2.8. The best solution would be that these customers stick with themes that are designed to work with Confluence 2.8. I don't think it's a good idea for us to switch back to using the old theme system in our plugin... we want to support the newest features as a general rule. I propose we add a new web item plugin that works with older themes. We would ship this plugin disabled by default. The name of this web item plugin might be: Web Item to show Add Diagram link (2.8+, legacy theme support) If a customer wants to use themes that haven't been designed to work with Confluence 2.8, they can disable the 2.8+ web item, and enable the 2.8+, legacy theme support plugin. How does that sound?
Hide
Permalink
Shannon Krebs added a comment - 30/Jun/08 4:49 PM

Yep, sounds like a good plan.

Show
Shannon Krebs added a comment - 30/Jun/08 4:49 PM Yep, sounds like a good plan.
Hide
Permalink
Shannon Krebs added a comment - 04/Jul/08 2:43 AM

Actually, there is one problem with just providing another web item, it assumes that all spaces in the instance are using the same theme. If there are multiple themes in use you still have a problem

Show
Shannon Krebs added a comment - 04/Jul/08 2:43 AM Actually, there is one problem with just providing another web item, it assumes that all spaces in the instance are using the same theme. If there are multiple themes in use you still have a problem
Hide
Permalink
Chris Kohlhardt added a comment - 11/Jul/08 7:00 PM

Gotcha... so I figured we'll let the users decided what to do by making both web items available. That way they can enable both web items if they have Confluence 2.8 compliant themes AND non 2.8 compliant themes.

Ultimately, this isn't our problem, but the theme developers who need to update their themes to be 2.8 compatible. We're just providing legacy web-items as a work around if people who choose to use themes that are not Confluence 2.8 compliant.

Show
Chris Kohlhardt added a comment - 11/Jul/08 7:00 PM Gotcha... so I figured we'll let the users decided what to do by making both web items available. That way they can enable both web items if they have Confluence 2.8 compliant themes AND non 2.8 compliant themes. Ultimately, this isn't our problem, but the theme developers who need to update their themes to be 2.8 compatible. We're just providing legacy web-items as a work around if people who choose to use themes that are not Confluence 2.8 compliant.
Hide
Permalink
Shannon Krebs added a comment - 13/Jul/08 6:21 AM

Legacy web-item added, disabled by default.

People who use the older themes over their entire site will now have an easy way to enable the old add diagram link without needing to edit the atlassian-plugin.xml.

Show
Shannon Krebs added a comment - 13/Jul/08 6:21 AM Legacy web-item added, disabled by default. People who use the older themes over their entire site will now have an easy way to enable the old add diagram link without needing to edit the atlassian-plugin.xml.
Hide
Permalink
Debi Kohlhardt added a comment - 10/Sep/08 6:41 AM

Note:
If you are running a theme that is not 2.8+ compliant and are not able to view the "add diagram link", please do the following:
Please enable the feature in the plugin "Legacy Add Diagram link".

Show
Debi Kohlhardt added a comment - 10/Sep/08 6:41 AM Note: If you are running a theme that is not 2.8+ compliant and are not able to view the "add diagram link", please do the following: Please enable the feature in the plugin "Legacy Add Diagram link".

People

Dates

  • Created:
    24/Jun/08 5:44 AM
    Updated:
    04/Dec/09 5:04 PM
    Resolved:
    13/Jul/08 6:21 AM
Bug tracking and project tracking for software development powered by Atlassian JIRA (v4.1.2#531) | Report a problem | Request a feature | Contact administrators