[#GLIFFY-661] Confluence 2.9 compatibility

Gliffy Product

Confluence 2.9 compatibility

Created: 14/Jun/08 02:06 AM Updated: 30/Jul/08 04:35 AM

Component/s:

Confluence Plugin Integration

Affects Version/s:

Gliffy Plugin for Confluence - 1.4.0

Fix Version/s:

Gliffy Plugin for Confluence - 1.4.1

Security Level:

Anyone may view

Issue Links:

Related

This issue is related to:

~~GLIFFY-751~~ Remove Struts from Plugin

Description

« Hide

GPFC is currently broken against confluence 2.9 m3.

The plugin seems to install ok, but when going to edit a diagram you get the generic: There was a data error processing your requst....

In the log there isn't much info, the problem appears to be with struts:

2008-06-14 16:59:51,000 DEBUG [http-8080-Processor3] [gliffy.core.util.PropertyManager] getInstance Getting instance
2008-06-14 17:00:04,265 ERROR [http-8080-Processor4] [apache.struts.action.RequestProcessor] processMapping null /clientopendiagram
 -- url: /plugins/servlet/gliffyapi/clientopendiagram | userName: shannon

All

Comments

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Chris Kohlhardt - 16/Jun/08 12:48 PM

We may try to remove struts completely in the next release of the plugin.

[ Permlink | « Hide ]

Chris Kohlhardt - 22/Jun/08 08:56 AM

Yah, sounds like the milestone builds are unstable. Good plan.

[ Permlink | « Hide ]

Shannon Krebs - 10/Jul/08 07:36 AM

Tried with milestone 5, still the same problem.

I don't know enough about struts to know whats going on yet, just looking at the config, in the error message where it says it can't find /clientopendiagram shouldn't it be looking for /gliffyapi/clientopendiagram

[ Permlink | « Hide ]

Chris Kohlhardt - 11/Jul/08 07:33 PM

Shannon,

In the version of Struts that we ship with our plugin, Jonathan Nolen actually modified some of the class loading code. This was a long time ago, but I'm wondering if there was perhaps a long standing class loader issue in Confluence, which is now fixed?

I'm guessing that Struts isn't able to load the config file, which is why we see these errors. Can you look some more armed with this information?

thx!

-chris

[ Permlink | « Hide ]

Chris Kohlhardt - 14/Jul/08 02:15 PM

Hi Shannon,

Dave, Clint and I have been discussing this issue, and we think it might be easiest to simply remove Struts from Gliffy all together.

We don't really use any of the features of Struts anyways, and we think it would be a lot simpler for future integrations to get Struts out of the picture.

So, here's the plan:

1 - I'm going to remove Struts from all Confluence Plugin code used on the 1.4.1 branch
2 - Once this is done, we can revisit ~~GLIFFY-661~~ and see if there are any Confluence 2.9 issues that need resolving

This should save you from having to try and work through the potentially really annoying class loader issues.

Sound good?

[ Permlink | « Hide ]

Shannon Krebs - 14/Jul/08 03:16 PM

If its not going to be much work to get rid of it that sounds like a good plan, would probably justify a "1.5" release since its a pretty significant change :-\

I'm still not exactly sure what is going on with the struts stuff in 2.9, it seems like the url that gets passed to the servlet class is different, missing the gliffyapi part which is why the config is not finding the right implementation class. I did a quick mode the the struts config and made it work, but this would obviously require a different binary for the different confluence versions.

[ Permlink | « Hide ]

Shannon Krebs - 15/Jul/08 03:39 PM

From a forum post by Jonathan Nolen, fixing PLUG-11 seems to have changed the expected url within the servlet.

[ Permlink | « Hide ]

Matthew Jensen - 30/Jul/08 12:53 AM

Hey guys, we are getting ready to release Confluence 2.9 and I wanted to know how you've gone with this issue. Is there anything one of us Atlassians can help with?

Are you planning on working around the issue for now or is your immediate plan to remove struts?

[ Permlink | « Hide ]

Shannon Krebs - 30/Jul/08 04:35 AM

@Matthew, This issue should be resolved with the 1.4.1 release. The plan is to release this version around the same time as Confluence 2.9.

If you want a snapshot build to do some testing or to deploy on C.A.C, please create an issue in the support project so we can attach it there.