[#GLIFFY-580] diagrams with special characters in name break when trying to remove - Gliffy

Details

Type: Bug
Status: Tested
Priority: Major
Resolution: Fixed
Affects Version/s: Gliffy Plugin for Confluence - 1.4.0
Fix Version/s: Gliffy Plugin for Confluence - 1.4.0
Component/s: Confluence Plugin Integration
Security Level: Anyone may view

Description:

Hide

The example I've found so far is " [ ] " there may be others

java.util.regex.PatternSyntaxException: Unclosed character class near index 32
\{gliffy:name=[poilkjhlkjh(.*?)\}
                                ^
	at java.util.regex.Pattern.error(Pattern.java:1713)
	at java.util.regex.Pattern.clazz(Pattern.java:2254)
	at java.util.regex.Pattern.sequence(Pattern.java:1818)
	at java.util.regex.Pattern.expr(Pattern.java:1752)
	at java.util.regex.Pattern.compile(Pattern.java:1460)
	at java.util.regex.Pattern.(Pattern.java:1133)
	at java.util.regex.Pattern.compile(Pattern.java:823)
	at java.lang.String.replaceAll(String.java:2190)
	at com.gliffy.confluencePlugin.action.RemoveDiagramAction.execute(RemoveDiagramAction.java:231)

Show

The example I've found so far is " [ ] " there may be others

java.util.regex.PatternSyntaxException: Unclosed character class near index 32
\{gliffy:name=[poilkjhlkjh(.*?)\}
                                ^
	at java.util.regex.Pattern.error(Pattern.java:1713)
	at java.util.regex.Pattern.clazz(Pattern.java:2254)
	at java.util.regex.Pattern.sequence(Pattern.java:1818)
	at java.util.regex.Pattern.expr(Pattern.java:1752)
	at java.util.regex.Pattern.compile(Pattern.java:1460)
	at java.util.regex.Pattern.(Pattern.java:1133)
	at java.util.regex.Pattern.compile(Pattern.java:823)
	at java.lang.String.replaceAll(String.java:2190)
	at com.gliffy.confluencePlugin.action.RemoveDiagramAction.execute(RemoveDiagramAction.java:231)

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Shannon Krebs added a comment - 13/May/08 6:24 AM

Also we need to catch the case where the user put \ at the start of the macro to indicate no to parse the macro to the confluence renderer.

Show

Shannon Krebs added a comment - 13/May/08 6:24 AM Also we need to catch the case where the user put \ at the start of the macro to indicate no to parse the macro to the confluence renderer.

Hide

Permalink

Shannon Krebs added a comment - 14/May/08 5:42 AM

another broken (edge) use case: all diagram macros in a page with the same diagram name will be removed even if they reside on different pages.

Show

Shannon Krebs added a comment - 14/May/08 5:42 AM another broken (edge) use case: all diagram macros in a page with the same diagram name will be removed even if they reside on different pages.

People

Assignee:

Shannon Krebs

Reporter:

Shannon Krebs
Votes:

0

Watchers:

0

Dates

Created:

07/May/08 3:25 AM

Updated:

09/Oct/08 12:02 PM

Resolved:

17/May/08 11:23 PM