History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: GLIFFY-580
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Shannon Krebs
Reporter: Shannon Krebs
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Gliffy Product

diagrams with special characters in name break when trying to remove

Created: 07/May/08 03:25 AM   Updated: 09/Oct/08 12:02 PM
Component/s: Confluence Plugin Integration
Affects Version/s: Gliffy Plugin for Confluence - 1.4.0
Fix Version/s: Gliffy Plugin for Confluence - 1.4.0
Security Level: Anyone may view


 Description  « Hide
The example I've found so far is " [ ] " there may be others
java.util.regex.PatternSyntaxException: Unclosed character class near index 32
\{gliffy:name=[poilkjhlkjh(.*?)\}
                                ^
	at java.util.regex.Pattern.error(Pattern.java:1713)
	at java.util.regex.Pattern.clazz(Pattern.java:2254)
	at java.util.regex.Pattern.sequence(Pattern.java:1818)
	at java.util.regex.Pattern.expr(Pattern.java:1752)
	at java.util.regex.Pattern.compile(Pattern.java:1460)
	at java.util.regex.Pattern.(Pattern.java:1133)
	at java.util.regex.Pattern.compile(Pattern.java:823)
	at java.lang.String.replaceAll(String.java:2190)
	at com.gliffy.confluencePlugin.action.RemoveDiagramAction.execute(RemoveDiagramAction.java:231)


 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Shannon Krebs - 13/May/08 06:24 AM
Also we need to catch the case where the user put \ at the start of the macro to indicate no to parse the macro to the confluence renderer.

Shannon Krebs - 14/May/08 05:42 AM
another broken (edge) use case: all diagram macros in a page with the same diagram name will be removed even if they reside on different pages.