History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: GLIFFY-544
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Shannon Krebs
Reporter: Shannon Krebs
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Gliffy Product

Change web item text for adding diagram in confluence 2.8

Created: 13/Mar/08 03:56 AM   Updated: 09/Oct/08 12:40 PM
Component/s: Confluence Plugin Integration
Affects Version/s: None
Fix Version/s: Gliffy Plugin for Confluence - 1.4.0
Security Level: Anyone may view

Issue Links:
Related
 


 Description  « Hide
In confluence 2.8 the page web items have been moved into a drop down menu called "Add". This means we only need the text "Diagram" rather then "Add Diagram" to appear in the link.

See http://developer.atlassian.com/jira/browse/MARK-63 for similar problem with the social bookmarking plugin.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Chris Kohlhardt - 06/May/08 08:09 AM
Hi Shannon,

This one might also be able to be solved be make the Add Diagram link text different depending on the version of Confluence that is running. Can you please look into this?

thanks!

-chris


Shannon Krebs - 08/May/08 05:39 AM - edited
The link text (and location) is controlled through the atlassian-plugin.xml file. We need to setup a new web item to display in the correct location in the menu, with the correct text and control if this is included with a new condition based on the build number. (I have implemented exactly the same thing for the social bookmarking plugin...).

Unfortunately it looks like the base Condition interface moved packages sometime around confluence 2.3. This means we can't build a single jar that works from release 2.2-> 2.8 since the condition class needs to be declared in the plugin.xml file.

Since we already bundle a different jar for pre 2.3 confluence this should be able to be done by hacking with the build a bit more.


Chris Kohlhardt - 27/May/08 10:11 AM
Hi Shannon,

What have you done with this so far? I noticed that the 2.2 specific plugin is failing to install because of a problem with the 'Add Diagram' link... can you please look into this?

http://cpb-cp-2-2.gliffy.com/admin/plugins.action?pluginKey=com.gliffy.integration.confluence

thx!

-chris


Shannon Krebs - 01/Jun/08 01:15 AM
I've changed the way this works so the ConfluenceVersionNumber condition is only uncommented for the 2.3+ build, if you supply a web item for a location that the theme doesn't know about it doesn't get displayed anyway, so leaving the menu web item in the 2.2 build doesn't cause any problems.