[#GLIFFY-528] Add diagram link displayed when users don't have add permission - Gliffy

Details

Type: Bug
Status: Tested
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: Gliffy Plugin for Confluence - 1.4.0
Component/s: Confluence Plugin Integration
Security Level: Anyone may view

Description:

Hide

The "Add Diagram" link on the menu bar seems to be shown based on having the create/edit page permission. But to create a Gliffy diagram users need the create attachment permission as well.

If a user with create page permission but not create attachment permission clicks on the add diagram link they get a blank page.

The error in the log is:

2008-02-17 21:15:01,750 WARN [http-8080-Processor4] [com.opensymphony.xwork.DefaultActionInvocation] executeResult No result defined for action com.gliffy.confluencePlugin.action.AddDiagramAction and result pagenotpermitted

Show
The "Add Diagram" link on the menu bar seems to be shown based on having the create/edit page permission. But to create a Gliffy diagram users need the create attachment permission as well. If a user with create page permission but not create attachment permission clicks on the add diagram link they get a blank page. The error in the log is: 2008-02-17 21:15:01,750 WARN [http-8080-Processor4] [com.opensymphony.xwork.DefaultActionInvocation] executeResult No result defined for action com.gliffy.confluencePlugin.action.AddDiagramAction and result pagenotpermitted

Issue Links

This issue is related to:
~~GLIFFY-544~~ Change web item text for adding diagram in confluence 2.8

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Chris Kohlhardt added a comment - 06/May/08 8:02 AM

I briefly spoke to Jens about this last week at the Atlassian User Group, and he seems to think it may be possible to fix this programatically. Can you please give it a shot?

Show

Chris Kohlhardt added a comment - 06/May/08 8:02 AM I briefly spoke to Jens about this last week at the Atlassian User Group, and he seems to think it may be possible to fix this programatically. Can you please give it a shot?

Hide

Permalink

Shannon Krebs added a comment - 18/May/08 4:08 AM

The AttachmentPermissionCondition is what we need, unfortunately that doesn't exist in the 2.2 versions of confluence. Will have to create our own version of it.

Show

Shannon Krebs added a comment - 18/May/08 4:08 AM The AttachmentPermissionCondition is what we need, unfortunately that doesn't exist in the 2.2 versions of confluence. Will have to create our own version of it.

Hide

Permalink

Shannon Krebs added a comment - 01/Jun/08 1:17 AM

new CreateAttachmentPermissionCondition has been added for the 2.2 and 2.3+ builds.

Show

Shannon Krebs added a comment - 01/Jun/08 1:17 AM new CreateAttachmentPermissionCondition has been added for the 2.2 and 2.3+ builds.

People

Assignee:

Shannon Krebs

Reporter:

Shannon Krebs
Votes:

0

Watchers:

0

Dates

Created:

17/Feb/08 5:17 AM

Updated:

09/Oct/08 12:56 PM

Resolved:

01/Jun/08 1:17 AM