Gliffy

I agree. To my mind the border should be black and the attribute to {gliffy} should be border=true or border=false.

In the diagram editor itself, the property sheet for the diagram could have some border properties, minimally
on/off, thickness, and color. The advantage of putting border properties in the diagram itself is that they would also apply
to exported versions of the diagram.

In The Gliffy Plugin for Confluence, the border is actually in the HTML itself, which is generated by the {gliffy} macro. It does seem to make sense to address this as a Macro option.

You'll notice that the actual image does not contain a border.

An alternative solution would be to have a global setting on the border.... thoughts on that? It would then effect the border on ALL diagrams in the Confluence install.

Personally I'd be fine with having it globally off but ideally it should be an option on the {gliffy} macro.

I would say that a global setting would be only incrementally better.

Yet another option would be never to have a border. The image has a canvas, and so you could have the option of creating one in the image, along with the size properties. That could then be used to generate the HTML or could be added to the image. In any event, per-image is better than global.

Something I've been thinking about while looking at some other issues, if we make the border configurable in the gliffy macro we may need to include the params in all of the actions that display diagrams. Users could think they are looking at a different image if the border suddenly changes when they click on the view large diagram for example.

Good point Shannon.

I guess I feel like specifying the border color makes this more complex than it should be. I'd prefer to keep this simple for now, and simply having yes/no for border. The default should be 'yes'.

-chris

This diagram was posted in the Sandbox of our test Confluence page. Note the fact there is no boarder.

I've added the border as an optional parameter to the gliffy macro. The border is now applied on a surrounding div to make it a bit more consistant. The example given in this issue where there is no border seems to be caused by confluence css styles (at least in 2.8).

To remove border from wiki page insert "border=false" into the Gliffy Marco {gliffy}, or use the Marco Browser support (scroll bar in wiki page editing mode) and uncheck the 'diagram border' box.