[#GLIFFY-40] Clicking "Save and Close" when Session times out causes diagram to be lost.

Gliffy Product

Clicking "Save and Close" when Session times out causes diagram to be lost.

Created: 13/Nov/07 06:08 PM Updated: 05/Mar/08 06:35 PM

Component/s:

Confluence Plugin Integration

Affects Version/s:

None

Fix Version/s:

Gliffy Plugin for Confluence - 1.3.6

Security Level:

Anyone may view

Description

« Hide

Migrated from: http://developer.atlassian.com/jira/browse/GLFY-25

1. Create a diagram
2. Let session timeout.
3. Click Save and Close.
Expected Result: Confluence should request login. Once logged in, diagram should display.

Actual Result: Confluence requests login. Once logged in, diagram does not show. It is lost.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Chris Kohlhardt added a comment - 01/Dec/07 12:31 PM

Looks like struts isn't configured to handle error case correctly for requests with no params.

@400000004751a7e125a2644c 2007-12-01 12:28:39,630 WARN [resin-tcp-connection-j2ee.wiki.gliffy.com:6802-23] [apache.struts.action.ActionMapping] findForward Unable to find 'errorCaught' forward.
@400000004751a8061bf084ec 2007-12-01 12:29:16,468 ERROR [resin-tcp-connection-j2ee.wiki.gliffy.com:6802-17] [core.action.client.ClientSaveDiagramAction] logThrowable Throwable caught...
@400000004751a8061bf0948c Thrown object:java.lang.NullPointerException
@400000004751a8061bf09874 Short Description:java.lang.NullPointerException
@400000004751a8061bf0a044 Message:null
@400000004751a8061bf0a42c Stack trace:

[ Permlink | « Hide ]

Shannon Krebs added a comment - 27/Feb/08 06:27 PM

Logging out in another tab while editing a diagram produces a similar situation. However testing this with confluences own editor also causes changes to be lost in this situation.

Is there some way that the front end can be changed so that it doesn't redirect to the viewing page if it detects a failure to save the diagram? Also if we could push the error message from the server into the front end as well as the general contact support message that might give the user a better idea of what has gone on.

The saving grace for the confluence editor when this happens is that confluence now has a feature to save drafts of pages as you edit them, perhaps gliffy could also add this feature. (I'm not sure where the temp draft data would get saved in confluence, page properties possibly?)

[ Permlink | « Hide ]

Chris Kohlhardt added a comment - 27/Feb/08 07:59 PM

Saving draft content is a bigger issue that I'd like to put off for now. (We're going to implement real time collaboration on the hosted application which will include auto-save, and we'll likely solve the draft problem using something similar)

I guess I was hoping there would be a way to detect that the session has timed out. I noticed that there does seem to be Ajax support built into Confluence... I wonder if there is a way to detect the session timed out through that? If we can figure out a request that can tell us that the session has timed out, we could certainly handle this on the client.

Can you please check into this possibility?

[ Permlink | « Hide ]

Chris Kohlhardt added a comment - 03/Mar/08 04:14 PM

This has been fixed by:

1) If a user tries to save a diagram and does not have permissions, we handle this error more gracefully
2) A message specific to the Confluence integration tells users that they likely had a session timeout, and they should log back in to save their work.